fix(core): disable scheduledPublishing and tasks if /features returns error
#7517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…api returns error
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
pedrobonamin
requested review from
a team and
rexxars
and removed request for
a team
pedrobonamin
changed the title
/features returns error
pedrobonamin
changed the title
/features returns error/features returns error
|
No changes to documentation |
|
Component Testing Report Updated Sep 17, 2024 3:36 PM (UTC) ✅ All Tests Passed -- expand for details
|
pedrobonamin
commented
Sep 17, 2024
| <Container width={1} paddingTop={4}> | ||
| <Box paddingTop={4} paddingX={4}> | ||
| <ErrorCallout | ||
| description="You do not have permission to edit schedules." |
There was a problem hiding this comment.
ℹ️ We don't have translations in scheduledPublishing
Instead of showing the same error that we show when the request fails we add an specific not enabled error.
**Current error **
Updated error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some users have reported that they see the upsell ui even though the feature is enabled for the project.
That is due to the
featuresapi returning an error if the user doesn't have the right permissions to query it.This PR adds the same check for
scheduledPublishingandtasksplugins.In
commentswe are currently doing that check here https://github.com/sanity-io/sanity/blob/edx-1599/packages/sanity/src/core/comments/hooks/useResolveCommentsEnabled.ts#L42-L43What to review
Are this changes ok?
Testing
New tests have been introduced to guard this behavior.
Notes for release
Disable schedule publishing and tasks plugin if user doesn't have the right access.