-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sanity): refine error UI #7520
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
02dca51
to
aad64c8
Compare
No changes to documentation |
Component Testing Report Updated Sep 24, 2024 8:56 AM (UTC) ✅ All Tests Passed -- expand for details
|
5b7c332
to
411f74f
Compare
packages/sanity/src/structure/panes/documentList/DocumentListPaneContent.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me, and a great addition! Just one minor nit.
3461bef
to
324489d
Compare
324489d
to
71919a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This branch introduces UI refinements to the
StudioErrorBoundary
component. The aim is to make this error UI less intimidating for users.Additionally, the "Copy error details" action has been added to the document list error UI.
Global error
Before
After (production build)
After (development build)
Document list error
Before
After
What to review
StudioErrorBoundary
is rendered outside ofLocaleProvider
, and therefore the text cannot be internationalised. Is that okay?ErrorActions
(which is now used inside document lists), cannot be internationalised (the retry button in document lists was previously internationalised). Is that okay?Testing
Notes for release