Remove references to implicit globals document and Text
#7532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@silvertech-daniel is attempting to deploy a commit to the Sanity Sandbox Team on Vercel. A member of the Team first needs to authorize it. |
|
Appreciate the |
|
@rexxars it's the opposite, I replaced |
My bad! 😅 Thanks for submitting this! |
rexxars
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I replaced references to the global
documentwith thedocparameter andnew Textwithdoc.createTextNode. I only found this in the MS Word-generated html preprocessor. This should fix the errors that I hit while running the portable text conversion on certain html in jsdom.What to review
Double-check that this is a fix of a mistake.
Testing
I have not tested this outside of edits to the package in the
node_modulesof my projectNotes for release
@sanity/block-toolspackage's html to portable text preprocessing of word-generated html which broke outside of browsers