Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vision): add API version 2025-02-19 #8707

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

geball
Copy link
Contributor

@geball geball commented Feb 20, 2025

Description

Adds v2025-02-19 to the API version dropdown list in Vision.

Notes for release

  • v2025-02-19 brings breaking changes and should be one of the API versions in Vision's dropdown for testing.
  • This should be released as part of the changes that make published the default perspective.

@geball geball requested a review from markmichon February 20, 2025 04:13
@geball geball requested a review from a team as a code owner February 20, 2025 04:13
@geball geball requested review from juice49 and removed request for a team February 20, 2025 04:13
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 4:14am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 4:14am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 4:14am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 20, 2025 4:14am
test-next-studio ⬜️ Ignored (Inspect) Feb 20, 2025 4:14am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

⚡️ Editor Performance Report

Updated Thu, 20 Feb 2025 04:22:04 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 27.8 efps (36ms) 29.4 efps (34ms) -2ms (-5.6%)
article (body) 75.2 efps (13ms) 69.7 efps (14ms) +1ms (-/-%)
article (string inside object) 28.6 efps (35ms) 28.6 efps (35ms) +0ms (-/-%)
article (string inside array) 25.6 efps (39ms) 26.0 efps (39ms) -1ms (-1.3%)
recipe (name) 45.5 efps (22ms) 47.6 efps (21ms) -1ms (-4.5%)
recipe (description) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 19.6 efps (51ms) 19.2 efps (52ms) +1ms (+2.0%)
synthetic (string inside object) 18.5 efps (54ms) 19.2 efps (52ms) -2ms (-3.7%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 36ms 38ms 40ms 458ms 313ms 9.9s
article (body) 13ms 16ms 23ms 76ms 190ms 5.3s
article (string inside object) 35ms 40ms 45ms 236ms 340ms 6.7s
article (string inside array) 39ms 42ms 46ms 152ms 121ms 6.6s
recipe (name) 22ms 24ms 26ms 40ms 0ms 7.2s
recipe (description) 19ms 20ms 21ms 42ms 0ms 4.7s
recipe (instructions) 6ms 7ms 8ms 17ms 0ms 3.2s
synthetic (title) 51ms 56ms 68ms 395ms 988ms 13.3s
synthetic (string inside object) 54ms 57ms 70ms 131ms 1125ms 8.7s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 34ms 38ms 41ms 424ms 128ms 9.5s
article (body) 14ms 20ms 34ms 206ms 405ms 5.8s
article (string inside object) 35ms 39ms 51ms 215ms 251ms 6.8s
article (string inside array) 39ms 43ms 45ms 140ms 228ms 6.9s
recipe (name) 21ms 23ms 27ms 41ms 2ms 7.3s
recipe (description) 19ms 21ms 24ms 39ms 0ms 4.7s
recipe (instructions) 6ms 9ms 10ms 25ms 0ms 3.4s
synthetic (title) 52ms 55ms 70ms 389ms 938ms 13.4s
synthetic (string inside object) 52ms 57ms 79ms 453ms 1091ms 8.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.97% 54926 / 127815
🔵 Statements 42.97% 54926 / 127815
🔵 Functions 48.13% 2794 / 5805
🔵 Branches 79.48% 10631 / 13375
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/@sanity/vision/src/apiVersions.ts 0% 0% 0% 0% 1-10
Generated in workflow #30735 for commit 39c0788 by the Vitest Coverage Report Action

Copy link
Contributor

Component Testing Report Updated Feb 20, 2025 4:29 AM (UTC)

❌ Failed Tests (4) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 22s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 2m 1s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 58s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 17s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ❌ Failed (Inspect) 1m 57s 14 0 1
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 54s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 2m 56s 20 0 1
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 15s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 2m 1s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@geball geball merged commit 7195b11 into next Feb 21, 2025
62 checks passed
@geball geball deleted the feat/add-vision-version branch February 21, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants