This repository was archived by the owner on Jun 19, 2020. It is now read-only.
Conversation
sapegin
reviewed
May 7, 2017
sapegin
left a comment
Owner
There was a problem hiding this comment.
I’d put all generated files to dist folder. As a side effect you could avoid this ugly .m.js.
Author
|
@sapegin That was my first idea, but people using the library directly (i.e without a module bundler, or without something reading the I also suggest to move the What do you think? |
Owner
|
I don’t know how many people still use the library but I won’t mind path change. So |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sapegin Here is a PR for #58.
I did not want to make lot of changes so:
jquery.mosaicflow.jsto a newjquery.mosaicflow.m.jsusing ES6 import.jquery.mosaicflow.jsis just the result of babel executed onjquery.mosaicflow.m.jsfile.