[WIP][DNM] First batch of specs for libsass parser backport #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
feature/libsass-parser-backport
branch
15 times, most recently
from
0101339 to
8e6c120
Compare
mgreter
force-pushed
the
feature/libsass-parser-backport
branch
14 times, most recently
from
bc68cb9 to
78561e6
Compare
mgreter
force-pushed
the
feature/libsass-parser-backport
branch
4 times, most recently
from
096ff2d to
a9d117c
Compare
mgreter
force-pushed
the
feature/libsass-parser-backport
branch
from
5f88139 to
8a93046
Compare
|
The current diff is about around where I want to aim for libsass 4.0. Will take me probably one week alone to sort out, rebase and squash all changes into groups that make sense to review ... |
|
@nex3 I seem to stumble a lot over the error "HRX::ParseError: Parse error on line 1, column 17 of spec/libsass/variable-scoping/blead-global/expanding/at-root.hrx: Invalid character U+000D". This seems to do with CRLF vs LF feeds. Not sure why the HRX parser fails about them with a hard error? My naive perl parser processes them without a problem ... |
Combine into one to see changes to master. Will split out commits once finished.
mgreter
force-pushed
the
feature/libsass-parser-backport
branch
from
e705206 to
67f14dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/libsass#2918