-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add xctest support #1005
base: main
Are you sure you want to change the base?
feat: Add xctest support #1005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Json Schema
Missing json schema update 🙏 See https://github.com/saucelabs/saucectl/tree/68fdc19a9eec4c8282d372b9ac9b2d7ea73589af/api/v1alpha/framework for framework specific schemas.
After you make changes to the relevant schemas and include it in the global schema as well, the final combined schema has to be re-generated via make schema
.
E2E Tests
We have at least one e2e test for each framework/workflow we support. Here's one for xcuitest. We'll need one for xctest as well 🙏
EnvFlag map[string]string `yaml:"-" json:"-"` | ||
} | ||
|
||
// Xcuitest represents xcuitest apps configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Xcuitest represents xcuitest apps configuration. | |
// Xctest represents xctest apps configuration. |
ARMRequired: d.armRequired, | ||
|
||
// Overwrite device settings | ||
RealDeviceKind: strings.ToLower(xcuitest.IOS), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for consistency (since this const exists in both packages):
RealDeviceKind: strings.ToLower(xcuitest.IOS), | |
RealDeviceKind: strings.ToLower(xctest.IOS), |
Description
Adds
xctest
test type support. Unlikexcuitest
it doesn't require a "test".ipa
but axctestrun
file which is an Apple plist format as a descriptor. Here is what the configuration looks like: