[WIP] Add internationalization as discussed in #17#20
Open
ssirois wants to merge 1 commit intosavoirfairelinux:masterfrom
Open
[WIP] Add internationalization as discussed in #17#20ssirois wants to merge 1 commit intosavoirfairelinux:masterfrom
ssirois wants to merge 1 commit intosavoirfairelinux:masterfrom
Conversation
Translate strings in both English and French.
ssirois
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17 by @ssirois
Changes proposed in this pull request:
langproperty on RingMe.UI constructorStatus
How to verify this change
Play with the
langproperty on the test page and realize that strings are available in both English and French.Additional notes
This is still WIP.
It is a first iteration to confirm that this is going the proper way. Discussions with people from the Ring project still needs to happen in order to align ourselves with there translation work-flow.
We also need to address #17 (comment)