Fixes #30, Add ESLint to project#36
Closed
Vishwajeetsinh98 wants to merge 1 commit intosavoirfairelinux:masterfrom
Closed
Fixes #30, Add ESLint to project#36Vishwajeetsinh98 wants to merge 1 commit intosavoirfairelinux:masterfrom
Vishwajeetsinh98 wants to merge 1 commit intosavoirfairelinux:masterfrom
Conversation
Contributor
|
Welcome to Ringme.js @Vishwajeetsinh98 and thank you for this contribution. Sadly enough, this issue has already been tackled by @DSchau in #32 Feel free to check the updated trunk and propose tweaks on ESLint. Be aware that there is also #34 by @nabrahamson in progress. I would really appreciate if you could transform this PR into a specific pre-commit hook PR. That would be great. Don't forget to document the pre-commit hook inside CONTRIBUTING.md. |
Contributor
|
@Vishwajeetsinh98 ping ? could you rebase your work ? |
Contributor
Author
|
@ventilooo I don't really think a rebase is required. All I've changed are dependencies and the package.json file. |
Contributor
Author
|
@ventilooo I think pulling will be safe. |
Contributor
|
@Vishwajeetsinh98 OK. I'll take a look and merge this manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30
Fixes #34
Changes proposed in this pull request:
Status
How to verify this change
eslint filenameAdditional notes
If so desired, a pre-commit hook change the package.json like so: