Fix for translating messages with quotation marks#69
Open
saamok wants to merge 1 commit into
Open
Conversation
…ation of messages containing quotation marks. Added exception name to table exists printout to help with diagnostics.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages containing quotation marks (" and possibly ') caused the translation database operations to fail, as the input to the SQL operations was not sanitized. I modified the db.execute calls to use sqlite3 parameter passing that automatically fixes the input so that stray quotation marks don't confuse the SQL interpreter. This should let twitchTransFreeNext properly translate messages that include quotation marks. (I also changed the exception handling for trying to create the table when it already exists to make it clearer where the message comes from, but that is not important for the quotation mark fix)