Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Order[Version] to simplify MillAlg.content #3540

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jan 12, 2025

With our Version data type and its Order instance we can simplify MillAlg.content because we can just check if a Mill version is >= 0.7 and < 0.9 for example without extracting the minor version number.

With our `Version` data type and its `Order` instance we can simplify
`MillAlg.content` because we can just check if a Mill version is >= 0.7
and < 0.9 for example without extracting the minor version number.
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (fbf5c4b) to head (c023138).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3540      +/-   ##
==========================================
- Coverage   89.81%   89.77%   -0.04%     
==========================================
  Files         171      171              
  Lines        4989     4970      -19     
  Branches      500      494       -6     
==========================================
- Hits         4481     4462      -19     
  Misses        508      508              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fthomas fthomas merged commit 757f9bb into main Jan 13, 2025
17 of 18 checks passed
@fthomas fthomas deleted the topic/simplify-MillAlg-content branch January 13, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants