Skip to content

fix: handle multiple params lists in for infer type #23197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

fix: handle multiple params lists in for infer type #23197

merged 2 commits into from
May 21, 2025

Conversation

kasiaMarek
Copy link
Member

fixes: scalameta/metals#7476

This looks like a lot of changes, but ApplyArgsExtractor file is extracted from NamedArgsCompletions.

@sjrd
Copy link
Member

sjrd commented May 20, 2025

This looks like a lot of changes, but ApplyArgsExtractor file is extracted from NamedArgsCompletions.

That's a textbook situation for doing 2 commits:

  1. 1st commit: Refactor-only that moves things around without changing the logic.
  2. 2nd commit: Change the logic for the fix, without moving things around.

@kasiaMarek kasiaMarek added the area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools label May 20, 2025
@kasiaMarek kasiaMarek requested a review from tgodzik May 21, 2025 08:51
tgodzik
tgodzik approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit 9d9e180 into scala:main May 21, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inferred type on type holes off-by-1 for extension methods
3 participants
@kasiaMarek @sjrd @tgodzik