Add jpath to VirtualFile (for pc) #23203
Draft
+55
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
requested changes
May 21, 2025
|
|
||
| override def sizeOption: Option[Int] = Some(content.length) | ||
|
|
||
| override def exists: Boolean = true |
There was a problem hiding this comment.
Do we need the overwrite? It's already (jpath eq null) || Files.exists(jpath)
There was a problem hiding this comment.
In presentation compiler tests it won't exist. Also MCP makes a fake file to get completions. Maybe the fie passed to pc should have the information if it's virtual of a not, so we could create a correct kind of source file here?
There was a problem hiding this comment.
Ach right, maybe it's worth a comment it explain it.
| * @return the created virtual file | ||
| */ | ||
| def this(path: JPath, content: Array[Byte]) = { | ||
| this(path.toString.replace(java.io.File.separatorChar, '/'), content) |
There was a problem hiding this comment.
Suggested change
| this(path.toString.replace(java.io.File.separatorChar, '/'), content) | |
| this(jpath.getFileName().toString(), path) | |
| this.content = content |
wouldn't make sense? I think / is only used to get the last element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalameta/metals#7460