Make runtimeChecked a standard feature #23262
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
approved these changes
May 25, 2025
|
Follow up should be to recommend this instead of |
|
@bishabosha The last commit changes the one occurrence of |
bishabosha
reviewed
May 25, 2025
| @@ -922,7 +922,7 @@ class UncheckedTypePattern(argType: Type, whyNot: String)(using Context) | |||
| i"""|Type arguments and type refinements are erased during compile time, thus it's | |||
| |impossible to check them at run-time. | |||
| | | |||
| |You can either replace the type arguments by ${hl("_")} or use `@unchecked`. | |||
| |You can either replace the type arguments by ${hl("_")} or use `.runtimeChecked`. | |||
There was a problem hiding this comment.
Actually this error message is the one legitimate use for unchecked, case _: List[Int @unchecked] =>the other error message is elsewhere - but as I type this I'm not at my computer
There was a problem hiding this comment.
Ah yes, well spotted. I'll revert the commit.
The runtimeChecked implementation was accepted in the SIP meeting of May 23, 2025. Since the the feature has been around for long, and is quite uncontroversial, I think we can just merge it for 3.8. No preview phase should be needed.
odersky
force-pushed
the
enable-runtimechecked
branch
from
0cce292 to
057ea91
Compare
mbovel
reviewed
May 27, 2025
Co-authored-by: Matt Bovel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtimeChecked implementation was accepted in the SIP meeting of May 23, 2025. Since the feature has been around for long, and is quite uncontroversial, I think we can just merge it for 3.8. No preview phase should be needed.
We should merge this PR for 3.8 RC1.