Skip to content

Remove unnecessary uses of uncheckedNN #23344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

noti0na1
Copy link
Member

No description provided.

@noti0na1 noti0na1 requested a review from Copilot June 10, 2025 15:38
Copilot

This comment was marked as resolved.

@noti0na1 noti0na1 requested a review from olhotak June 10, 2025 15:40
@noti0na1 noti0na1 marked this pull request as ready for review June 10, 2025 15:40
@som-snytt
Copy link
Contributor

Wow, copilot is quite the nag!

@olhotak
Copy link
Contributor

olhotak commented Jun 10, 2025

Should we extend #23327 to also warn for uncheckedNN? It seems it would just need to treat it the same way as nn, or am I missing something?

@noti0na1
Copy link
Member Author

noti0na1 commented Jun 10, 2025

Should we extend #23327 to also warn for uncheckedNN? It seems it would just need to treat it the same way as nn, or am I missing something?

It's hard to do that because uncheckedNN is defined and only used in dotty.

Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you an get the CI to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants