Make typeArgs in QuotesImpl work for AnnotatedTypes #24018
Merged
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchyb
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
This is a good improvement even regardless of the regression. I only worry a bit because the same information could have also been accessed via explicitly matching against AppliedType(_, tArgs), which will also break now (although thankfully not in the linked project, where I only saw the problem with .typeArgs). Still, I understand that adjusting type inference to fit possible outdated macro implementations would be far too impractical
|
@jchyb Yes, I think the solution needs to be to make macros more robust with respect to variations. Adding an annotation to a type should not be a breaking change. |
|
Wow, my PR is after your. Your laptop must be running faster on the tests than mine 😂 |
noti0na1
reviewed
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24006