Add table metadata to operation check error messages

[brfrn169]

Description

This PR adds table metadata information to operation check error messages to help users understand the expected table schema when an operation validation fails.

Related issues and/or PRs

N/A

Changes made

• Added table metadata information to operation check error messages.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

[gemini-code-assist]

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the diagnostic capabilities of the system by enriching operation validation error messages with relevant table metadata. This enhancement aims to guide users more effectively when their operations do not conform to the defined table schema, thereby streamlining debugging and development workflows.

Highlights

• Enhanced Error Messages: Operation check error messages now include table metadata, providing users with more context about the expected table schema when validation fails.
• New Error Code: A new error code, OPERATION_CHECK_ERROR_UPDATE_CONDITION (0280), has been introduced to specifically address invalid conditions in Update operations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances error messages for operation checks by including table metadata, which is a great improvement for user diagnostics. The changes are consistently applied across OperationChecker and CoreError. I've also noticed the addition of a more specific error, OPERATION_CHECK_ERROR_UPDATE_CONDITION, in ScalarDbUtils, which improves clarity.

My main feedback is to ensure this new error message also includes the table metadata to align with the overall goal of this PR. I've left a couple of suggestions to implement this, which would involve a minor refactoring of ScalarDbUtils.checkUpdate.

[Copilot]

Pull request overview

This PR enhances operation check error messages by adding table metadata information to help users understand the expected table schema when validation fails. The changes improve error diagnostics by providing contextual information about the table structure alongside the failing operation.

• Updates 11 operation check error message formats in CoreError.java to include table metadata parameter
• Introduces a new dedicated error code (OPERATION_CHECK_ERROR_UPDATE_CONDITION) for Update operation condition validation
• Updates all call sites in OperationChecker and SelectStatementHandler to pass table metadata to error messages

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
core/src/main/java/com/scalar/db/common/CoreError.java	Updated 11 error message formats to include table metadata parameter; added new error code OPERATION_CHECK_ERROR_UPDATE_CONDITION for Update-specific validation
core/src/main/java/com/scalar/db/common/checker/OperationChecker.java	Updated 15 buildMessage calls to include metadata parameter for enhanced error context
core/src/main/java/com/scalar/db/storage/objectstorage/SelectStatementHandler.java	Updated 2 buildMessage calls for ordering validation errors to include metadata
core/src/main/java/com/scalar/db/util/ScalarDbUtils.java	Changed error code from generic OPERATION_CHECK_ERROR_CONDITION to specific OPERATION_CHECK_ERROR_UPDATE_CONDITION for Update validation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[komamitsu]

LGTM! 👍

[Torch3333]

LGTM, thank you!