-
Notifications
You must be signed in to change notification settings - Fork 11
[DE-6014] Add support for limited access keys #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| @pytest.mark.skip( | ||
| reason="Skip Temporarily - Need to find issue with customObjectIndexingJobId" | ||
| ) | ||
| def test_box_pred_upload_embedding(CLIENT, model_run): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every other test (only 1 other one) that uses customObjectIndexingJobId is also skipped due to an apparently known issue with customObjectIndexingJobId. See here. Thus, this fix should be for a separate pr.
| # Important: Don't change this otherwise we will stop testing the earliest | ||
| # python version we have to support. | ||
| - image: python:3.7-buster | ||
| - image: python:3.7-bullseye |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python:3.7-buster was not even building in the circleci pipeline because it seems to be EOL and thus not supported anymore. Please advise if there is a better alternative than the one I chose.
Linear issue: https://linear.app/scale-epd/issue/DE-6014
Note: This allows the
api_keyandlimited_access_keyto be used together as well (let me know if you think this shouldn't me an option)Testing:
After updating tests to support limited access keys, all tests that passed before this change still pass via
poetry run pytest -q -m "not integration"Example usage with poetry:
Updated Documentation:
