Skip to content

Conversation

jtherin
Copy link
Member

@jtherin jtherin commented Sep 18, 2024

No description provided.

@github-actions github-actions bot added the k8s Kubernetes Kapsule issues, bugs and feature requests label Sep 18, 2024
@jtherin jtherin force-pushed the k8skubeconfig branch 5 times, most recently from f967445 to 710551c Compare September 19, 2024 08:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

❌ Patch coverage is 58.56777% with 162 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.25%. Comparing base (5bf53e0) to head (eed133c).
⚠️ Report is 845 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/k8s/v1/custom_kubeconfig.go 49.48% 121 Missing and 25 partials ⚠️
...nal/namespaces/k8s/v1/custom_kubeconfig_install.go 90.00% 2 Missing and 3 partials ⚠️
...ternal/namespaces/k8s/v1/custom_execcredentials.go 33.33% 2 Missing and 2 partials ⚠️
...nternal/namespaces/k8s/v1/custom_kubeconfig_get.go 85.71% 2 Missing and 2 partials ⚠️
internal/namespaces/k8s/v1/custom.go 78.57% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (eed133c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (eed133c)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4137       +/-   ##
===========================================
- Coverage   75.45%   56.25%   -19.20%     
===========================================
  Files         202      307      +105     
  Lines       44323    78336    +34013     
===========================================
+ Hits        33444    44071    +10627     
- Misses       9653    32838    +23185     
- Partials     1226     1427      +201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jtherin jtherin force-pushed the k8skubeconfig branch 2 times, most recently from 62cda48 to d4ab902 Compare September 19, 2024 12:05
KubeconfigAPIVersion = "v1"
KubeconfigKind = "Config"
installHint = `scaleway-cli (scw) is required to authenticate to the current cluster.
Installation instruction: https://github.com/scaleway/scaleway-cli#installation`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add documentation in the README about the feature you are trying to use? It could be a dedicated tutorial as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For customer view, norhing really changes, it still using old commands

@jtherin jtherin force-pushed the k8skubeconfig branch 14 times, most recently from 070a024 to 655624d Compare October 13, 2025 12:14
@jtherin jtherin marked this pull request as ready for review October 13, 2025 12:22
@jtherin jtherin requested a review from a team as a code owner October 13, 2025 12:22
@remyleone remyleone enabled auto-merge October 13, 2025 13:38
@remyleone remyleone added this pull request to the merge queue Oct 13, 2025
Merged via the queue into scaleway:master with commit c1a08c4 Oct 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

k8s Kubernetes Kapsule issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants