-
Notifications
You must be signed in to change notification settings - Fork 155
feat(k8s): rework kubeconfig handling #4137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f967445
to
710551c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4137 +/- ##
===========================================
- Coverage 75.45% 56.25% -19.20%
===========================================
Files 202 307 +105
Lines 44323 78336 +34013
===========================================
+ Hits 33444 44071 +10627
- Misses 9653 32838 +23185
- Partials 1226 1427 +201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
62cda48
to
d4ab902
Compare
07ffbaa
to
e059a23
Compare
KubeconfigAPIVersion = "v1" | ||
KubeconfigKind = "Config" | ||
installHint = `scaleway-cli (scw) is required to authenticate to the current cluster. | ||
Installation instruction: https://github.com/scaleway/scaleway-cli#installation` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add documentation in the README about the feature you are trying to use? It could be a dedicated tutorial as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For customer view, norhing really changes, it still using old commands
070a024
to
655624d
Compare
a1a30ca
to
eed133c
Compare
No description provided.