tests(instance/k8s): fix bump go-vcr to v4 #5119
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5119 +/- ##
=======================================
Coverage 57.45% 57.45%
=======================================
Files 308 308
Lines 67280 67280
=======================================
Hits 38657 38657
Misses 27182 27182
Partials 1441 1441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mia-Cross
force-pushed
the
bump_go_vcr_v4_k8s_fix
branch
from
3e51c3a to
45a6b04
Compare
Mia-Cross
added a commit
to Mia-Cross/scaleway-cli
that referenced
this pull request
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5109 and #5089
The
folderUsesVCRv4function had a bug that caused it to always returnfalse, therefore preventing the bump from actually having any effect. This PR fixes the function and re-records the cassettes, in the right version this time.