Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edge_services): add resources #2637

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jun 27, 2024

No description provided.

@yfodil yfodil changed the title Feat/edge services feat(edge_services): add resources Jun 27, 2024
@yfodil yfodil self-assigned this Jun 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 53.45016% with 425 lines in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (fe86049) to head (426accc).
Report is 112 commits behind head on master.

Files Patch % Lines
internal/services/edgeservices/testfuncs/checks.go 0.00% 130 Missing ⚠️
internal/services/edgeservices/testfuncs/sweep.go 0.00% 86 Missing ⚠️
...services/edgeservices/edge_services_cache_stage.go 72.59% 34 Missing and 3 partials ⚠️
...l/services/edgeservices/edge_services_dns_stage.go 75.00% 30 Missing and 5 partials ⚠️
...l/services/edgeservices/edge_services_tls_stage.go 73.68% 31 Missing and 4 partials ⚠️
internal/services/edgeservices/types.go 38.77% 28 Missing and 2 partials ⚠️
...al/services/edgeservices/edge_services_pipeline.go 74.07% 25 Missing and 3 partials ⚠️
...rvices/edgeservices/edge_services_backend_stage.go 77.77% 19 Missing and 3 partials ⚠️
internal/services/edgeservices/waiters.go 0.00% 20 Missing ⚠️
internal/services/edgeservices/helpers.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2637      +/-   ##
==========================================
- Coverage   71.43%   70.52%   -0.92%     
==========================================
  Files         277      343      +66     
  Lines       35875    34284    -1591     
==========================================
- Hits        25628    24178    -1450     
+ Misses       8028     7781     -247     
- Partials     2219     2325     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yfodil yfodil marked this pull request as ready for review June 27, 2024 15:36
@yfodil yfodil requested a review from remyleone as a code owner June 27, 2024 15:36
cacheStage, err := api.CreateCacheStage(&edge_services.CreateCacheStageRequest{
ProjectID: d.Get("project_id").(string),
BackendStageID: types.ExpandStringPtr(d.Get("backend_stage_id").(string)),
FallbackTTL: &scw.Duration{Seconds: 3600},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this value be explicitly set from the config?

@yfodil yfodil marked this pull request as draft July 2, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants