Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DateInput): range fixes #4741

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(DateInput): range fixes #4741

wants to merge 2 commits into from

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Feb 6, 2025

Summary

Type

  • Bug

Summarise concisely:

What is expected?

<DateInput />:

  • rework range logic: it is not possible to choose the end date before the start date, and once both have been selected, clicking on a new date will always reset the range (instead of changing the end value on some conditions)
  • fix styling issue on hover for days in range (and refactor of the code for those elements)

@lisalupi lisalupi added the bug Something isn't working label Feb 6, 2025
@lisalupi lisalupi requested a review from a team February 6, 2025 15:09
@lisalupi lisalupi self-assigned this Feb 6, 2025
@lisalupi lisalupi requested a review from matthprost as a code owner February 6, 2025 15:09
@lisalupi lisalupi requested review from fabienhebert and JulienSaguez and removed request for a team February 6, 2025 15:09
Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: 8180b2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 98.57143% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.01%. Comparing base (fc68c84) to head (8180b2b).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/DateInput/Context.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4741      +/-   ##
==========================================
+ Coverage   88.98%   89.01%   +0.02%     
==========================================
  Files         227      227              
  Lines        7974     8000      +26     
  Branches     3666     3627      -39     
==========================================
+ Hits         7096     7121      +25     
- Misses        878      879       +1     
Files with missing lines Coverage Δ
.../components/DateInput/components/CalendarDaily.tsx 100.00% <100.00%> (ø)
...omponents/DateInput/components/CalendarMonthly.tsx 100.00% <100.00%> (ø)
...s/ui/src/components/DateInput/components/Popup.tsx 96.07% <100.00%> (+0.07%) ⬆️
packages/ui/src/components/DateInput/index.tsx 98.73% <100.00%> (+0.01%) ⬆️
packages/ui/src/components/DateInput/Context.tsx 14.28% <0.00%> (-2.39%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9e923...8180b2b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants