Skip to content

Conversation

@lisalupi
Copy link
Collaborator

Summary

Type

  • Refactor

Summarise concisely:

What is expected?

  • Refactor component Slider to use vanilla extract instead of Emotion
  • Add prop "style" to Popup and Tooltip

@lisalupi lisalupi requested review from a team, fabienhebert and vincentaudebert and removed request for a team October 20, 2025 14:04
@lisalupi lisalupi requested a review from matthprost as a code owner October 20, 2025 14:04
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2025

🦋 Changeset detected

Latest commit: 543bb57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Major
@ultraviolet/nextjs Major
@ultraviolet/plus Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.76%. Comparing base (107fe0e) to head (543bb57).
⚠️ Report is 214 commits behind head on beta.

Files with missing lines Patch % Lines
.../src/components/Slider/components/DoubleSlider.tsx 75.00% 2 Missing ⚠️
...es/ui/src/components/Slider/components/Options.tsx 93.33% 1 Missing ⚠️
.../src/components/Slider/components/SingleSlider.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #5713      +/-   ##
==========================================
- Coverage   92.17%   91.76%   -0.41%     
==========================================
  Files         289      320      +31     
  Lines        7615     7042     -573     
  Branches     3149     2821     -328     
==========================================
- Hits         7019     6462     -557     
+ Misses        596      580      -16     
Files with missing lines Coverage Δ
packages/ui/src/components/Popup/index.tsx 93.46% <100.00%> (ø)
packages/ui/src/components/Slider/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Slider/styles.css.ts 100.00% <100.00%> (ø)
packages/ui/src/components/Tooltip/index.tsx 100.00% <ø> (ø)
...es/ui/src/components/Slider/components/Options.tsx 93.33% <93.33%> (-2.32%) ⬇️
.../src/components/Slider/components/SingleSlider.tsx 94.11% <83.33%> (-1.97%) ⬇️
.../src/components/Slider/components/DoubleSlider.tsx 91.03% <75.00%> (-2.42%) ⬇️

... and 97 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a45e9...543bb57. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants