Skip to content

impr(ARSN-475): Add bucketOwnerId field to ObjectMD model#2337

Merged
bert-e merged 2 commits intodevelopment/8.2from
improvement/ARSN-475/add_bucket_owner_id_to_object_md
Apr 1, 2025
Merged

impr(ARSN-475): Add bucketOwnerId field to ObjectMD model#2337
bert-e merged 2 commits intodevelopment/8.2from
improvement/ARSN-475/add_bucket_owner_id_to_object_md

Conversation

@tmacro
Copy link
Contributor

@tmacro tmacro commented Mar 28, 2025

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Mar 28, 2025

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to bump arsenal as well before merging 🙂

// object is a placeholder and is not up to date.
export const mdModelVersion = 6;
// Version 7 adds the "bucketOwnerId" attribute to the object metadata.
// This is set when the owner of the bucket is different from the owner-id of the object.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a bit more context here? To explain why we need it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least describe that owner-id is the requester account id for cross account put object

@scality scality deleted a comment from bert-e Mar 31, 2025
@bert-e
Copy link
Contributor

bert-e commented Mar 31, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.42%. Comparing base (79702c0) to head (a01688c).
Report is 2 commits behind head on development/8.2.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.2    #2337      +/-   ##
===================================================
+ Coverage            69.41%   69.42%   +0.01%     
===================================================
  Files                  217      217              
  Lines                17402    17409       +7     
  Branches              3606     3606              
===================================================
+ Hits                 12080    12087       +7     
  Misses                5318     5318              
  Partials                 4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tmacro tmacro force-pushed the improvement/ARSN-475/add_bucket_owner_id_to_object_md branch from dde44eb to a01688c Compare April 1, 2025 18:52
@tmacro
Copy link
Contributor Author

tmacro commented Apr 1, 2025

/approve

@bert-e
Copy link
Contributor

bert-e commented Apr 1, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

Please check the status of the associated issue ARSN-475.

Goodbye tmacro.

The following options are set: approve

@bert-e bert-e merged commit a01688c into development/8.2 Apr 1, 2025
7 checks passed
@bert-e bert-e deleted the improvement/ARSN-475/add_bucket_owner_id_to_object_md branch April 1, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants