- 
                Notifications
    
You must be signed in to change notification settings  - Fork 252
 
Improvement/cldsrv 724 object related functional tests #5987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: improvement/CLDSRV-724-multiple-backend-tests
Are you sure you want to change the base?
Improvement/cldsrv 724 object related functional tests #5987
Conversation
          Hello benzekrimaha,My role is to assist you with the merge of this Available options
 Available commands
 Status report is not available.  | 
    
          ❌ 52 Tests Failed:
 View the top 3 failed test(s) by shortest run time
 
 
 
 
 
 
 View the full list of 45 ❄️ flaky test(s)
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 To view more test analytics, go to the Test Analytics Dashboard  | 
    
327e859    to
    58f8c81      
    Compare
  
    69b2a4a    to
    c56ac68      
    Compare
  
    6d97621    to
    d8c1d88      
    Compare
  
    Issue: CLDSRV-724
c56ac68    to
    06547e0      
    Compare
  
    | `with ${partCount} parts`, done => { | ||
| process.stdout.write('***Running large MPU test***\n'); | ||
| let uploadId; | ||
| let uploadId; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| let uploadId; | |
| let uploadId; | 
| .catch(err => next(err)); | ||
| }, | ||
| next => { | ||
| process.stdout.write('putting parts\n'); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| process.stdout.write('putting parts\n'); | 
| if (err) { | ||
| process.stdout.write(`Error in timesLimit: ${err}\n`); | ||
| } | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (err) { | |
| process.stdout.write(`Error in timesLimit: ${err}\n`); | |
| } | 
| .then(data => { | ||
| assert.strictEqual(data.ETag, | ||
| `"${finalETag}-${partCount}"`); | ||
| process.stdout.write('get object successful\n'); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| process.stdout.write('get object successful\n'); | 
| // with number of parts at the end) | ||
| assert.strictEqual(res.ETag, | ||
| '"5bba96810ff449d94aa8f5c5a859b0cb-2"'); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indent looks wrong in github diff view
| 
               | 
          ||
| ETags = await Promise.all(uploadPromises); | ||
| 
               | 
          ||
| // Put empty object | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Put empty object | 
| Body: '', | ||
| })); | ||
| 
               | 
          ||
| // Put non-MPU object | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Put non-MPU object | 
| Body: generateContent(0), | ||
| })); | ||
| 
               | 
          ||
| // Complete multipart upload | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Complete multipart upload | 
| // eslint-disable-next-line no-unused-vars | ||
| const { $metadata, ...res } = await s3.send(new ListMultipartUploadsCommand({ Bucket: bucket })); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can as well just save the full object and use .$metadata in the callback? same below in this file
| it('should put an object and set the acl via query param', | ||
| done => { | ||
| async () => { | ||
| // Create a temporary file for upload | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Create a temporary file for upload | 
Issue : CLDSRV-724