impr(CLDSRV-771): Rate limit client wrapper for redis #5989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
tcarmet
approved these changes
Oct 27, 2025
tmacro
force-pushed
the
improvement/CLDSRV-767/inmem_counter_config_cache
branch
from
84fa622 to
eb4a19a
Compare
Base automatically changed from
improvement/CLDSRV-767/inmem_counter_config_cache
to
improvement/CLDSRV-766/bucket_rate_limiting
October 28, 2025 16:57
tmacro
force-pushed
the
improvement/CLDSRV-771/rate_limit_redis_client_wrapper
branch
from
d97a15f to
3317748
Compare
| } | ||
| } | ||
|
|
||
| let counterClient; |
There was a problem hiding this comment.
I'd call this instance
There was a problem hiding this comment.
Can we have some documentation on the script like what's the values for ARGV and KEYS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.