CLDSRV-770: parseRateLimitConfig unit tests #5991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files
@@ Coverage Diff @@
## improvement/CLDSRV-766/bucket_rate_limiting #5991 +/- ##
===============================================================================
+ Coverage 82.57% 82.65% +0.08%
===============================================================================
Files 194 194
Lines 12324 12325 +1
===============================================================================
+ Hits 10176 10187 +11
+ Misses 2148 2138 -10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
tcarmet
approved these changes
Oct 29, 2025
Comment on lines
+42
to
+46
| desc: '[rps] should throw an error if requestsPerSecond isn\'t an object', | ||
| input: { | ||
| requestsPerSecond: 'foo' | ||
| }, | ||
| throws: true, |
Contributor
There was a problem hiding this comment.
Can you be more explicit on the error thrown ?
Contributor
Author
There was a problem hiding this comment.
I'm not really sure how without tying it pretty closely to the implementation.
BourgoisMickael
approved these changes
Oct 30, 2025
tmacro
merged commit e0e0179
into
improvement/CLDSRV-766/bucket_rate_limiting
26 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the config loading code already in the feature branch.
Small deviation from the design to note:
burstCapacityis optionally configurable at the cluster level rather than being a constant.I thought this change was easy enough and would help us out when trying to determine the default value during testing.