fix: update worldIdentifiers list in RemapWorlds #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The World Browser was only showing the Default world because worldIdentifiers list wasn't being updated with new worlds. This fix ensures all worlds are visible in the World Browser dropdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where World Browser was only showing the Default world because worldIdentifiers list wasn't being updated when new worlds were created.
Problem
When creating additional worlds (besides Default), they weren't visible in the World Browser dropdown because worldIdentifiers list in Hierarchy class wasn't being updated in RemapWorlds method.
Solution
Updated RemapWorlds method to clear and repopulate worldIdentifiers list with all existing worlds.
How to Test
Before Fix
Only Default world was visible in World Browser dropdown
After Fix
All worlds are visible in World Browser dropdown