Remove deprecated CLI legacy flag-form shim#160
Merged
Conversation
The pre-clap flag-form compatibility layer (rewrite_legacy_argv and helpers) shipped in #98 for the migration window; the CLI surface is now the clap subcommand tree only, and legacy flags fail as ordinary clap usage errors. Drops the deprecated-forms section from docs/platform/CLI.md. Closes #102 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EXJT6YsDdt6tPkHNccaipp
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated pre-clap flag-form shim from sp42-cli (follow-up to #98). The CLI is now defined only by the clap subcommand tree; old flag invocations fail as normal clap usage errors, covered by a new regression test. Also drops the legacy-forms table from docs/platform/CLI.md.
Closes #102
🤖 Generated with Claude Code
https://claude.ai/code/session_01EXJT6YsDdt6tPkHNccaipp