-
Notifications
You must be signed in to change notification settings - Fork 54
Add LTS to SPEC 0 #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add LTS to SPEC 0 #389
Conversation
bsipocz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like phrasing this as LTS, it feels to be a nice extension and compromise!
I haven't looked in into the test failures, obviously the approval is not for any potentially relevant failures.
|
I think what's outlined in LTS is consistent with what scikit-learn is doing in scikit-learn/scikit-learn#30888. So I would like to ping @lesteve and @lucascolley to see if they have any thoughts or input. |
62246ef to
6cc9920
Compare
| {{< admonition note >}} | ||
| Certain projects (e.g., projects that have more resources) may wish to provide long-term support (LTS) of an additional year. | ||
|
|
||
| Specifically, for projects wishing to provide LTS we recommend that: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first sentence is that all projects should adopt a common policy. This goes against that, so I think we should acknowledge the discrepancy in some way. If we do not recommend one over the other, the first sentence might change to be "adopt one of two time-based poicies...". If we have a preference for the first but recognize the need for the other, we might say something to that effect here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions about the new text are inline.
If we were modifying other text:
- I don't understand the connection between the timeframe over which new releases support old dependency versions and the timeframe over which a given (feature) release will get bug fix releases. I think the SPEC would be more focused if it only mentions the former.
- The "Ecosystem Adoption" and "Implementation" sections are empty. Is that desirable?
- The background and motivation appears at the end, after the policy itself. Was that intentional?
- The SPEC only mentions limiting support duration as a motivation. Does it also recommend providing at least a certain amount of time - just not much more?
But if the intent is to address only LTS here, feel free to hide this comment as "off topic".
lucascolley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Matt's comments, but otherwise this looks like a useful change!
|
Observations from discussions here at EuroSciPy:
|
A toggle or tab for this would be nice! |
450cb01 to
41ba4f7
Compare
See scikit-learn/scikit-learn#30888 (comment).
Todo:
spec-0000/SPEC0_versions.py