Skip to content

Conversation

@lukasheinrich
Copy link
Contributor

@lukasheinrich lukasheinrich commented Mar 3, 2023

Description

Resolves #1427

I tried to implement some basic checks for handling toys as in Issue #1427

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR

@lukasheinrich lukasheinrich changed the title [WIP] first attempt on toy handling [WIP] feat: allow failing toys Mar 3, 2023
@matthewfeickert matthewfeickert added the feat/enhancement New feature or request label Mar 3, 2023
@matthewfeickert matthewfeickert changed the title [WIP] feat: allow failing toys feat: Allow failing toys Mar 3, 2023
@matthewfeickert matthewfeickert marked this pull request as draft March 3, 2023 16:57
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

❌ Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.88%. Comparing base (10488f0) to head (116f995).

Files with missing lines Patch % Lines
src/pyhf/infer/calculators.py 40.00% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2128      +/-   ##
==========================================
- Coverage   98.23%   97.88%   -0.35%     
==========================================
  Files          65       65              
  Lines        4193     4211      +18     
  Branches      591      595       +4     
==========================================
+ Hits         4119     4122       +3     
- Misses         45       56      +11     
- Partials       29       33       +4     
Flag Coverage Δ
contrib 97.69% <40.00%> (-0.28%) ⬇️
doctest ?
unittests-3.10 96.01% <40.00%> (-0.27%) ⬇️
unittests-3.11 96.01% <40.00%> (-0.27%) ⬇️
unittests-3.12 96.01% <40.00%> (-0.27%) ⬇️
unittests-3.8 96.01% <40.00%> (-0.27%) ⬇️
unittests-3.9 96.05% <40.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthewfeickert matthewfeickert added the API Changes the public API label Dec 13, 2023
@kratsg kratsg force-pushed the toy_handling_test branch from 803b842 to c41bb4d Compare July 5, 2024 18:28
@kratsg kratsg added the experiment/atlas Relevant to ATLAS's interests label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Changes the public API experiment/atlas Relevant to ATLAS's interests feat/enhancement New feature or request

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

Allow toys to fail

4 participants