Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(backport): Use notebook over jupyter #2508

Conversation

meeseeksmachine
Copy link

@meeseeksmachine meeseeksmachine commented May 31, 2024

Backport PR #2507: build: Use notebook over jupyter

* Backport PR https://github.com/scikit-hep/pyhf/pull/2507
* jupyter is a metapackage that is never updated, so defining the
  notebook dependency provides better control on the actual tools
  required.

@lumberbot-app lumberbot-app bot added build Changes that affect the build system or external dependencies chore Other changes that don't modify src or test files labels May 31, 2024
@matthewfeickert matthewfeickert self-assigned this May 31, 2024
@matthewfeickert matthewfeickert added the backport Backport PRs from main to release branch label May 31, 2024
@matthewfeickert matthewfeickert changed the title Backport PR #2507 on branch release/v0.7.x (build: Use notebook over jupyter) build(backport): Use notebook over jupyter May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/v0.7.x@1dc2b7e). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.7.x    #2508   +/-   ##
=================================================
  Coverage                  ?   98.19%           
=================================================
  Files                     ?       69           
  Lines                     ?     4547           
  Branches                  ?      804           
=================================================
  Hits                      ?     4465           
  Misses                    ?       49           
  Partials                  ?       33           
Flag Coverage Δ
contrib 97.73% <ø> (?)
doctest 98.02% <ø> (?)
unittests-3.10 96.19% <ø> (?)
unittests-3.11 96.19% <ø> (?)
unittests-3.12 96.19% <ø> (?)
unittests-3.7 96.17% <ø> (?)
unittests-3.8 96.21% <ø> (?)
unittests-3.9 96.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 6511a4d into scikit-hep:release/v0.7.x May 31, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch build Changes that affect the build system or external dependencies chore Other changes that don't modify src or test files
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants