Align with scikit-learn’s SelectorMixin API #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the estimator to comply with scikit-learn’s
SelectorMixinAPI. With this change, the estimator behaves consistently with scikit-learn’s native selectors, allowing it to plug seamlessly into any pipeline or utility that expects the standard selector interface.Importantly, the estimator’s underlying logic and outputs remain unchanged. The
SelectorMixinclass has been part of scikit-learn since version 0.11 (released in 2012), so this update introduces no backward-compatibility concerns.