Remove ase dependency and update ROY dataset #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at removing the dependency on the
ase
library. The update ofase
leads to issue #231. Since by now only the load of the ROY dataset depends onase
, getting rid of ase is easy and reasonable.This PR deletes the
xyz
file and saves the data of thexyz
file that is necessary for the example notebook inberan_roy_properties.npz
, together with the features originally stored inberan_roy_features.npz
. Because of the removal of thexyz
file, the visualization of the structures in the example is no longer usable. Perhaps we can consider preserving thexyz
file and letting users to open it withase
and then do the visualization.Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--232.org.readthedocs.build/en/232/