Combine renovate fix + nix-checks into one sequenced workflow#417
Merged
Conversation
Renovate dep-bump PRs need post-processing (per-module `go mod tidy`
and `nix-update` of vendor hashes) before the Nix checks can build
them. Today this happens in two parallel workflows: the doomed
nix-checks run starts at the same time as the fix and shows red until
the fix re-triggers it.
Combine them into a single ci workflow with proper ordering:
fix --> list --> {checks, packages} --> ci-pass
The fix job uses dorny/paths-filter to cheaply detect whether the PR
touches any of the files we know how to fix; if not, the rest of the
job no-ops and downstream jobs run normally. If the fix pushes
corrective commits, downstream jobs are skipped — the resulting
`pull_request synchronize` triggers a fresh CI run on the corrected
SHA that does the actual validation.
A new `ci-pass` aggregator (always() + needs all four) is the single
required status check for branch protection: it passes when either
the fix pushed (next run validates) or every downstream job
succeeded. Skipped fix (forks) or empty-fix paths fall through to
the downstream-result check, so non-Renovate PRs behave exactly as
before.
Supersedes the standalone update-vendor-hash / fix-renovate-prs
workflow and the standalone nix-checks workflow; both files are
removed.
- list now only checks needs.fix.outputs.pushed != true; if fix failed or was cancelled, list is skipped (default needs behavior) and ci-pass fails on the failure/cancelled result. - drop redundant if: needs.list.result == success on checks/packages; needs already short-circuits when list is skipped/failed. - collapse ci-pass to a contains(needs.*.result, ...) one-liner; the previous shell logic for distinguishing fix-pushed vs all-passed is unnecessary because a fix push retriggers CI on the new SHA and branch protection on the PR HEAD blocks merge until that succeeds.
trly
approved these changes
May 14, 2026
trly
left a comment
trly
left a comment
There was a problem hiding this comment.
Branch protection rules will need to get updated to address the change from nix-checks-pass to ci-pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate dep-bump PRs need post-processing (per-module
go mod tidyandnix-updateof vendor hashes) before the Nix checks can build them. Today this happens in two parallel workflows: the doomed nix-checks run starts at the same time as the fix and shows red until the fix re-triggers it.