Polarization correction #122
Open
+752
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can we use esspolarization to perform the correction?
There was a problem hiding this comment.
Right now we can't because of scipp/esspolarization#84
When that is fixed we should be able to use esspolarization to do the correction.
src/ess/estia/calibration.py
Outdated
Comment on lines
24
to
29
| def _kronecker_product(A, B): | ||
| return [ | ||
| [A[ia][ja] * B[ib][jb] for ja in range(2) for jb in range(2)] | ||
| for ia in range(2) | ||
| for ib in range(2) | ||
| ] |
There was a problem hiding this comment.
Can you clarify why we cannot use np.kron?
There was a problem hiding this comment.
The 2D arrays containing DataArray are treated by np.kron as 3D arrays, and that makes the result different from what we want.
src/ess/estia/calibration.py
Outdated
| '''Corrects the intensities for imperfections of polarizing components''' | ||
| return _linsolve(self.polarization_matrix, Is) | ||
|
|
||
| def correct_intensities_and_normalize_by_reference(self, Is): |
There was a problem hiding this comment.
Still missing type hints in many places.
Co-authored-by: Simon Heybrock <[email protected]>
|
Requires scipp/esspolarization#91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polarization correction for ESTIA
Only important differences from #108 are in
src/ess/estia/calibration.py: https://github.com/scipp/essreflectometry/pull/122/files#diff-df676f2a67f8251976ea2fcc161ea759d49deef6ef66c5adbf01d10665230077