feat: add reference column to reduction table #169
Conversation
jokasimr
changed the title
| self.run_number_max = widgets.IntText( | ||
| value=9999, description='', layout=widgets.Layout(width='5em') | ||
|
|
||
| def _init_display_component(self): |
There was a problem hiding this comment.
Not really the intention of this PR, but since you split this into 'components', you could also make different classes and compose them.
There was a problem hiding this comment.
Yeah it's possible. Right now I don't think they are independent enough for that. There would be tight coupling between the main GUI class and the "components" anyway, and in that case it's easier to just keep them together. Eventually maybe some of them could be refactored out as separate components.
| @@ -491,6 +509,9 @@ def add_row(_): | |||
| 'QBins': 391, | |||
| 'QStart': 0.01, | |||
| 'QStop': 0.3, | |||
| 'Reference': self.reference_table.data.iloc[0]['Sample'] | |||
| if len(self.reference_table.data) > 0 | |||
There was a problem hiding this comment.
This looks like there can be more than 1 element in self.reference_table.data but only the first one is used in 'Reference'. What happens to the other elements?
There was a problem hiding this comment.
This sets the default value of the Reference column to be the first entry in the reference table.
It's up to the user to change that to something else if there are more than one entry in the reference table.
Fixes #150
First change is refactoring to make it a bit easier to understand what part of the init function deals with what components of the GUI.
Second change adds a "reference" column to the reduction table to let the user specify what reference measurement to use for that reflectivity curve.