Feat/#101 lecture lecturematerial relationship#116
Open
rmrn65 wants to merge 9 commits intodevelopmentfrom
Open
Feat/#101 lecture lecturematerial relationship#116rmrn65 wants to merge 9 commits intodevelopmentfrom
rmrn65 wants to merge 9 commits intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request solves issue:
Closes: #101
Which app is this issue related to?
Admin Panel- Not created yetTypes of changes
Wiki Updates
Testing checklist
Security Filters - For API Only
Please make sure to add the respective Security Filters before submitting a PR
Compatibility tests - For E-Learning React App Only
What changes have been done within this issue?
Added relationship in the
Lectureclass withLectureMaterialas a list oflectureMaterials. Also within theLectureclass Iimplemented Lombok meaning getters setters hashCode and equals are deleted.
Modified update and add function in service so that they handle the list of
lectureMaterials. This has been done by goingthrough the list of
lectureMaterialsreceived from theLecture entryand updating the list after searching in thelectureMaterialRepositoryfor theLectureMaterialentries.There is a bug where if you want to update the lectureMaterial list of one lecture it will replace the already existent entries,
but due to the team needing the push as soon as possible, I left a comment and an issue so that it can be fixed later
The serialization issue does NOT need to be used in our situation. Later for other relationships, we will need to use DOT classes so we can display only what we need in the JSON got by the GET query
How should this be manually tested?
Use PATCH HTML query of
/lectureand try adding a list of lecture materials only by adding ids, or by adding the whole objectlike in the image shown below.
Screenshots or example usage