Externalize formats from mods into mod folders#1565
Open
EnPassant4264 wants to merge 13 commits intoscoopapa:mainfrom
Open
Externalize formats from mods into mod folders#1565EnPassant4264 wants to merge 13 commits intoscoopapa:mainfrom
EnPassant4264 wants to merge 13 commits intoscoopapa:mainfrom
Conversation
There's some other stuff in here, don't worry about it
add all the changes before committing
It works!
Fixed this locally, guess I forgot to move it
This externalizes the formats.ts construction to clear merge conflicts happening every time a mod updates. Now, the file simply imports the formats and places them in order, so it will only change and do so minorly when a mod is created or removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing the work started on this PR to have mods define their own formats, rather than storing them all in config/formats.ts. The main change from that PR is that there's now a single formats.ts file for each mod folder that stores an array of all of the formats (though most of them have only one, it means it takes no work if any chooses to change that), which are passed into the config and placed together. While formats of a mod can still be placed separately by referencing their index in their array, I chose not to do that in the few instances where they had been previously.
Unfortunately, the two official Smogon mods (Bad N' Boosted and Gen 3 Colosseum) don't load correctly from being in the new official-formats file, so I had to update the client as well to read them.