Fixing aliases for specific mons with hyphenated names#47
Open
KirbyRider1337 wants to merge 1 commit intoscoopapa:mainfrom
Open
Fixing aliases for specific mons with hyphenated names#47KirbyRider1337 wants to merge 1 commit intoscoopapa:mainfrom
KirbyRider1337 wants to merge 1 commit intoscoopapa:mainfrom
Conversation
Simply put they cause infinite recursion (Feed Kommo in -> Replace with Kommo-o -> Hyphen present, feed Kommo in) and as such crash builders for mods. This fix checks to see if we're about to feed the same argument(s) into "get" as earlier and if we are, does not perform the internal "get" call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply put they cause infinite recursion (Feed Kommo in -> Replace with Kommo-o -> Hyphen present, feed Kommo in) and as such crash builders for mods. This fix checks to see if we're about to feed the same argument(s) into "get" as earlier and if we are, skips perform the internal "get" call.