feat(coreutils): update for newer GNU coreutils #1457
Conversation
|
Failing test on Fedora looks unrelated. Running on Fedora locally it's fine. Ran like: |
pixelb
changed the title
pixelb
changed the title
Yeah this is a known issue, see #1435 |
|
If you rebase on main the test should succeed now |
Adjust for changes in GNU coreutils. Valid as of coreutils 9.5 (Mar 2024). Add completions for: base32, basenc, cksum, comm, numfmt, readlink, realpath, shred, shuf, stat, sync Adjust completions for: chgrp: add --from dd: remove deprecated *_bytes flags
| [[ $w == -@(R|-recursive) ]] && opts="-H -L -P" && break | ||
| done | ||
| _comp_compgen -- -W '-c -h -f -R -v --changes --dereference | ||
| _comp_compgen -- -W '-c -h -f -R -v --changes --dereference --from |
There was a problem hiding this comment.
Just a note, we'd be better off parsing instead of hardcoding, but that's something for another PR.
| _comp_compgen -- -X "*.$sumtype" -W '"${files[@]}"' | ||
| } && | ||
| complete -F _comp_cmd_sha256sum b2sum md5sum sha{,1,224,256,384,512}sum | ||
| complete -F _comp_cmd_sha256sum b2sum cksum md5sum \ |
There was a problem hiding this comment.
We should add a cksum test + Makefile.am symlinking/cleanup and .gitignore entries.
| a2ps awk base64 bash bc bison cat chroot colordiff cp \ | ||
| a2ps awk base{32,64,nc} bash bc bison cat chroot colordiff comm cp \ | ||
| csplit cut date df diff dir du enscript expand fmt fold gperf \ | ||
| grep grub head irb ld ldd less ln ls m4 mkdir mkfifo mknod \ | ||
| mv netstat nl nm objcopy objdump od paste pr ptx readelf rm rmdir \ | ||
| sed seq shar sort split strip sum tac tail tee \ | ||
| mv netstat nl nm numfmt objcopy objdump od paste pr ptx readelf \ | ||
| readlink realpath rm rmdir sed seq shar shred \ | ||
| shuf sort split stat strip sum sync tac tail tee \ |
There was a problem hiding this comment.
Let's add basic tests for the added commands (at least ones test/generate outputs) plus address issues if any crop up. Some likely will e.g. on Alpine.
3 participants
Adjust for changes in GNU coreutils.
Valid as of coreutils 9.5 (Mar 2024).
Add completions for:
base32, basenc, cksum, comm, numfmt, readlink, realpath,
shred, shuf, stat, sync
Adjust completions for:
chgrp: add --from
dd: remove deprecated *_bytes flags