-
Notifications
You must be signed in to change notification settings - Fork 391
style(_comp_compgen): call _comp_compgen_filedir
directly
#964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
approved these changes
May 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
May 8, 2023
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
May 10, 2023
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
May 21, 2023
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
May 21, 2023
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
May 26, 2023
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
May 26, 2023
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
May 28, 2023
scop#954 (comment) scop#964 scop#962 (comment) Co-authored-by: Ville Skyttä <[email protected]>
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
May 28, 2023
scop#954 (comment) scop#964 scop#962 (comment) Co-authored-by: Ville Skyttä <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally posted by @scop in #954 (comment)
Originally posted by @akinomyoga in #954 (comment)
c91e6c4 is the rewrite.
I'm including the variable name changes in
_comp_compgen_filedir
to avoid conflicts that can be introduced when_comp_comgen -v var filedir
is used (08477b4).I added a
@remarks
in the function code document (ea3a88e) but haven't added it to the style guide. It seems even usage ofxfunc
is currently undocumented indoc/*.md
, so it is consistent to describe both_comp_xfunc
and_comp_compgen
if we are to add commentary of the_comp_compgen
usage in the style guide.