Skip to content

fix: use _comp_compgen for multiline COMPREPLY=($(compgen ...)) #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2023

Conversation

akinomyoga
Copy link
Collaborator

This is another round for _comp_compgen.

Also, word lists are re-folded on column 80 to fit the lines within 79 characters.

Copy link
Owner

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, pre-approved with some single vs double quote comments.

@scop
Copy link
Owner

scop commented May 9, 2023

(Maybe refactor or feat rather than fix for the commit messages though, your call.)

@akinomyoga
Copy link
Collaborator Author

akinomyoga commented May 9, 2023

(Maybe refactor or feat rather than fix for the commit messages though, your call.)

Actually, the rewriting using _comp_split/_comp_compgen (#948) has been originally planned for the protection against pathname expansions (failglob/nullglob) and word splitting (IFS), so they are fix in the sense that they solve the actual problems.

Edit: But I actually used refactor in the previous commit.

@scop scop merged commit 4d82296 into scop:master May 9, 2023
@akinomyoga akinomyoga deleted the _comp_compgen-2 branch May 9, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants