Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functionality with Rails 3.2 time_zone_select helper #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jaredmoody
Copy link

Use erb to drop in the ActiveSupport mappings so that we can properly
select the value from the helper.

Use erb to drop in the ActiveSupport mappings so that we can properly
select the value from the helper.
@hayksaakian
Copy link

please merge pull request. the plugin doesn't seem to work on the latest 3.2 as it is.

@bmorrison
Copy link

Many thanks for this. gem 'detect_timezone_rails', :git => 'https://github.com/elevation/detect_timezone_rails' and all was well.

@chrisdpeters
Copy link

I tried using the source at https://github.com/elevation/detect_timezone_rails, but I get this error when running rake assets:precompile:

rake aborted!
undefined method `tzinfo' for nil:NilClass
  (in /Users/cpeters/.rvm/gems/ruby-1.9.3-p125/bundler/gems/detect_timezone_rails-ba752d91669c/vendor/assets/javascripts/jquery.detect_timezone.js.erb)
/Users/cpeters/.rvm/gems/ruby-1.9.3-p125/bundler/gems/detect_timezone_rails-ba752d91669c/vendor/assets/javascripts/jquery.detect_timezone.js.erb:34:in `block in singletonclass'
/Users/cpeters/.rvm/gems/ruby-1.9.3-p125/bundler/gems/detect_timezone_rails-ba752d91669c/vendor/assets/javascripts/jquery.detect_timezone.js.erb:65530:in `instance_eval'
/Users/cpeters/.rvm/gems/ruby-1.9.3-p125/bundler/gems/detect_timezone_rails-ba752d91669c/vendor/assets/javascripts/jquery.detect_timezone.js.erb:65530:in `singletonclass'
/Users/cpeters/.rvm/gems/ruby-1.9.3-p125/bundler/gems/detect_timezone_rails-ba752d91669c/vendor/assets/javascripts/jquery.detect_timezone.js.erb:65528:in `__tilt_70298514971360'

Using Rails 3.2.13.

@chrisdpeters
Copy link

P.S. I was able to resolve by referencing the commit prior to the latest:

gem "detect_timezone_rails", github: "elevation/detect_timezone_rails", ref: "367557636e33549e318e6e89c7323791af4afb56"

@hayksaakian
Copy link

Thanks for the tip @chrisdpeters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants