feat: require approval for gh issue create

[i-am-thor]

Summary

• gate gh issue create behind Slack human approval instead of immediate execution
• preserve footer injection, GitHub assignee attribution, and created-issue alias registration on approved execution
• update docs plus unit/E2E coverage for the new fail-closed and pending-approval behavior

Testing

• pnpm exec vitest run packages/common/src/proxies.test.ts packages/remote-cli/src/gh-disclaimer.test.ts packages/remote-cli/src/mcp-handler.test.ts packages/remote-cli/src/policy.test.ts
• GitHub Actions: Unit Tests
• GitHub Actions: Core E2E

---

AI-generated — verify before acting. View Thor context

[Copilot]

Pull request overview

Routes gh issue create through the existing Slack-button human approval path instead of executing immediately. Effective args (with Thor footer and trigger-user assignee already applied) are stored in a new "gh" approval-store namespace, the /exec/mcp resolve resolver gains a local executor for ghIssueCreate, and the created-issue correlation alias is only registered after the approved gh command succeeds. Fail-closed when there's no Thor session, anchor, or Slack thread.

Changes:

• Add ghIssueCreate approval tool type, schema, and Slack presentation in @thor/common, plus a "gh" approval store namespace and executeGhIssueCreateApproval executor in remote-cli's mcp-handler.
• Branch /exec/gh issue create into requestGhIssueCreateApproval and extract issue-URL alias helpers into a new gh-issue-alias.ts.
• Update E2E, unit tests, skill docs, and add a plan doc to reflect the new approval-required behavior.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/common/src/approval-events.ts	Adds ghIssueCreate tool name, schema, discriminated union member, and no-op disclaimer injection.
packages/common/src/approval-presentation.ts	Adds Slack presentation builder and shellQuote helper for ghIssueCreate.
packages/common/src/index.ts	Re-exports GhIssueCreateApprovalArgsSchema.
packages/common/src/proxies.ts	Excludes ghIssueCreate from the MCP-approved-tool inventory consistency check.
packages/common/src/proxies.test.ts	Updates registry test to skip ghIssueCreate.
packages/remote-cli/src/mcp-handler.ts	Adds "gh" approval store, display-arg parser, executeGhIssueCreateApproval, and requestGhIssueCreateApproval.
packages/remote-cli/src/index.ts	Routes gh issue create to approval; moves alias helpers to a new module.
packages/remote-cli/src/gh-issue-alias.ts	New module exporting registerGitCorrelationAlias, parseCreatedIssueCorrelationKey, and registerCreatedIssueCorrelationAlias.
packages/remote-cli/src/gh-disclaimer.test.ts	Updates issue-create tests to expect approval flow and alias registration only after approval resolve.
scripts/test-e2e.sh	Updates attribution E2E to expect fail-closed and exec_gh_pending_approval log markers.
docker/opencode/config/skills/using-gh/SKILL.md	Documents that issue creation requires human approval.
docs/plan/2026052501_gh-issue-create-approval.md	New design/plan document.

Comments suppressed due to low confidence (1)

packages/remote-cli/src/index.ts:663

• After this diff, validated gh issue create requests are always routed into the approval branch above (the only way effectiveArgs[0] === "issue" && effectiveArgs[1] === "create" can fall through is if isGhHelpRequest(effectiveArgs) is true, i.e. --help/-h, which never produces an issue URL). The post-exec alias registration on lines 660–662 is now dead code for issue creation — registerCreatedIssueCorrelationAlias is only invoked from executeGhIssueCreateApproval in mcp-handler.ts. Consider removing this branch to avoid future confusion.

      if ((result.exitCode ?? 0) === 0) {
        if (effectiveArgs[0] === "issue" && effectiveArgs[1] === "create") {
          registerCreatedIssueCorrelationAlias(ids.sessionId, cwd, result.stdout);
        }
      }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

[daohoangson]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Resolved in 83d974f.

[daohoangson]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Resolved in 9452713.