Skip to content

delete SKIP_TOKENS_PARSER setting #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

noviluni
Copy link
Collaborator

@noviluni noviluni commented Jun 25, 2020

As mentioned here: #722

I think we can delete this setting based on:

@noviluni noviluni added this to the v1.0.0 milestone Jun 25, 2020
@noviluni noviluni mentioned this pull request Jun 25, 2020
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #728 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   95.23%   95.35%   +0.12%     
==========================================
  Files         302      304       +2     
  Lines        2560     2585      +25     
==========================================
+ Hits         2438     2465      +27     
+ Misses        122      120       -2     
Impacted Files Coverage Δ
dateparser/parser.py 98.92% <100.00%> (-0.01%) ⬇️
dateparser/calendars/__init__.py 95.06% <0.00%> (-0.45%) ⬇️
dateparser/languages/validation.py 93.43% <0.00%> (-0.44%) ⬇️
dateparser/search/detection.py 94.23% <0.00%> (-0.11%) ⬇️
dateparser/date.py 98.00% <0.00%> (-0.01%) ⬇️
dateparser/search/search.py 99.35% <0.00%> (-0.01%) ⬇️
dateparser/calendars/jalali_parser.py 100.00% <0.00%> (ø)
dateparser/__init__.py 100.00% <0.00%> (ø)
dateparser/conf.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc38bb...bf58427. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #728 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files         304      304           
  Lines        2662     2663    +1     
=======================================
+ Hits         2542     2543    +1     
  Misses        120      120           
Impacted Files Coverage Δ
dateparser/parser.py 99.02% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b256f14...26db985. Read the comment docs.

@noviluni noviluni mentioned this pull request Jun 26, 2020
@noviluni noviluni merged commit ed0b7f8 into scrapinghub:master Jul 15, 2020
@noviluni noviluni mentioned this pull request Sep 25, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants