-
Notifications
You must be signed in to change notification settings - Fork 91
is online? #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
is online? #376
Conversation
Honestly, I thought block monitors were always named directly after the block (so, |
|
FINALLY a new block! |
|
This would be amazing! Mostly just because it's the first new block in a while (besides face sensing) but also it would be pretty useful. |
KManolov3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Congrats on a new block! 🎉
|
I recommend changing both the wording on the block and in the monitor to just |
|
@ericrosenbaum, I've renamed the block to |
I still think the name is confusing. "online?" could mean whether the project has internet connectivity functionality, whether or not it's actively using them at that moment, or whether it's being run in the online editor vs. the offline editor. Something like "connected to internet?" would solve the third one, but not the first two. Maybe "internet available?", but I'm not sure. The other thing is whether or not a block like this makes sense in the sensing category, as opposed to one of the extensions. To me it seems a bit out of place (generally anything relating to the internet is abstracted away there), but I can't think of any better place to put it, and an extension that only has one block wouldn't make sense. |
|
You did say in the OP you were open to feedback, but IDK if it' too late for that now. |
there's also another possible interpretation, "is [a user, possibly the creator of the project] currently online on the Scratch website?" (so like, a person might try to use the "is online?" block to make a project that shows if they're online on the website or not). though "online?" does probably have a lower chance of users interpreting it that way than "is online?", and the two names you suggested don't have that possibility at all |
See also scratchfoundation/scratch-blocks#3412
Proposed Changes
Add a new block to the Sensing category to detect whether or not the system is online (has an active Internet connection).
Reason for Changes
Scratch users have discovered ways to check for online status, most commonly by repeatedly using the Translate extension. While I applaud the ingenuity, this approach generates excess load on the Translate infrastructure. Scratchers and the Scratch Team will all have a better time if we provide a direct way to check for online status.
I'm open to feedback, including:
online?Test Coverage
Tested locally:
