-
Notifications
You must be signed in to change notification settings - Fork 93
feat: Add ClipboardDataManager for clipboard history storage #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Hey @shrimpnaur 👋 Thanks so much for the PR! Could we ask that you fix the license headers and KTLint issues? You can also set up |
|
Thanks so much, @shrimpnaur! We'll try to get to the review in the coming days :) |
angrezichatterbox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @shrimpnaur.
I have added a suggestion. However I would like room to be used instead of this. I think room would be very helpful to use in long term. We did SQL queries without room earlier as we had existing Sqlite databases. However we could think about changing them as well at some point.
| */ | ||
| data class ClipboardItem( | ||
| val id: Long, | ||
| val text: String, | ||
| val timestampMs: Long, | ||
| val isPinned: Boolean, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be made into a separate file rather than having it here itself. Import and use it here instead.
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR implements the data storage layer for the clipboard history feature (Issue #459).
Changes Made:
ClipboardDataManagerclass that manages clipboard item storage using SQLiteClipboardDataManagerTestwith comprehensive test coverage for all operationsClipboardDataManagerinto theDatabaseManagers, following the existing patternsTesting:
./gradlew testThis is PR #1 from the following PRs (forming different parts of the implementation)
Related issue