fixed initialization and onremove method #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripter-co
reviewed
Nov 22, 2016
| @@ -20,7 +23,7 @@ L.Polyline.plotter = L.Polyline.extend({ | |||
| this._bindMapClick(); | |||
| } | |||
| }, | |||
| onRemove: function(){ | |||
| onRemove: function(map){ | |||
There was a problem hiding this comment.
are you just passing in map here for consistency?
There was a problem hiding this comment.
No, just look at line 32 in your sources or 35th in my fork.
You use map variable but it is not defined in function scope
L.Polyline.prototype.onRemove.call(this, map);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you haven't defined map in onRemove method, and reinit values in initialize, so it just continuing the path when another plotter is created