Skip to content

Commit baf8da0

Browse files
devversionatscott
authored andcommitted
ci: re-enable dev-app building in components-repo-unit-tests job (angular#43798)
Re-enables the building of the `src/dev-app` package in the components repo when the components-repo-unit-test job runs. We previously disabled the dev-app because it was not compatible with template typechecking of ngtsc. This should be fixed now and can re-enable it. This could be valuable for having some actual real test scenarios of type checking. PR Close angular#43798
1 parent 167fb2b commit baf8da0

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

scripts/ci/run_angular_components_unit_tests.sh

+2-3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@ cd ${COMPONENTS_REPO_TMP_DIR}
1313
# Create a symlink for the Bazel binary installed through NPM, as running through Yarn introduces OOM errors.
1414
./scripts/circleci/setup_bazel_binary.sh
1515

16-
# Now actually run the tests. The dev-app and all its subpackages are excluded as they fail
17-
# to compile due to limitations in Ivy's type checker (see FW-1352 and FW-1433)
18-
bazel test --build_tag_filters=-docs-package,-e2e,-browser:firefox-local --test_tag_filters=-e2e,-browser:firefox-local -- src/... -src/dev-app/...
16+
# Now actually run the tests.
17+
bazel test --build_tag_filters=-docs-package,-e2e,-browser:firefox-local --test_tag_filters=-e2e,-browser:firefox-local -- src/...

0 commit comments

Comments
 (0)